Skip to content

fix: pass the correct argument when navigating back after leaving/deleting the group [WPB-19133]#4573

Open
MohamadJaara wants to merge 1 commit intodevelopfrom
mo/fix/wrong-snackbar-when-leaving-a-goup
Open

fix: pass the correct argument when navigating back after leaving/deleting the group [WPB-19133]#4573
MohamadJaara wants to merge 1 commit intodevelopfrom
mo/fix/wrong-snackbar-when-leaving-a-goup

Conversation

@MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Feb 5, 2026

https://wearezeta.atlassian.net/browse/WPB-19133


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

pass the correct argument when navigating back after leaving/deleting the group

Solutions

now the correct you left is showing

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara requested a review from saleniuk February 5, 2026 16:58
@MohamadJaara MohamadJaara requested review from Garzas and sbakhtiarov and removed request for saleniuk February 5, 2026 16:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.45%. Comparing base (6e9bafe) to head (71626f1).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4573   +/-   ##
========================================
  Coverage    48.45%   48.45%           
========================================
  Files          575      575           
  Lines        19833    19832    -1     
  Branches      3315     3315           
========================================
  Hits          9610     9610           
+ Misses        9208     9207    -1     
  Partials      1015     1015           
Files with missing lines Coverage Δ
...sations/details/GroupConversationDetailsNavArgs.kt 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e9bafe...71626f1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant