Skip to content

Revert new public apis #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coriolinus merged 3 commits into from
May 22, 2025
Merged

Revert new public apis #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0eecd01
Revert "feat: `ProposalQueue::from_committed_proposals` is public"
coriolinus May 22, 2025
04f570b
Revert "feat: add a public getter for proposal store to public group"
coriolinus May 22, 2025
a1b8833
Revert "feat: it is possible to cheaply get a `PublicGroup` from a `M…
coriolinus May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openmls/src/group/core_group/proposals.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ impl ProposalQueue {
/// don't need filtering.
/// This functions does the following checks:
/// - ValSem200
pub fn from_committed_proposals(
pub(crate) fn from_committed_proposals(
ciphersuite: Ciphersuite,
backend: &impl OpenMlsCryptoProvider,
committed_proposals: Vec<ProposalOrRef>,
Expand Down
6 changes: 0 additions & 6 deletions openmls/src/group/mls_group/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,6 @@ pub struct MlsGroup {
state_changed: InnerState,
}

impl AsRef<PublicGroup> for MlsGroup {
fn as_ref(&self) -> &PublicGroup {
self.group.public_group()
}
}

impl MlsGroup {
// === Configuration ===

Expand Down
4 changes: 0 additions & 4 deletions openmls/src/group/public_group/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,10 +329,6 @@ impl PublicGroup {
pub(crate) fn owned_encryption_keys(&self, leaf_index: LeafNodeIndex) -> Vec<EncryptionKey> {
self.treesync().owned_encryption_keys(leaf_index)
}

pub fn proposal_store(&self) -> &ProposalStore {
&self.proposal_store
}
}

// Test functions
Expand Down
Loading