You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When viewing another user's device details, the E2EI certificate status incorrectly shows "Not activated" even when the other user has a valid E2EI certificate.
Cause
The GetMLSClientIdentityUseCase returns a generic failure when StorageFailure.DataNotFound is encountered. This error occurs when there is no common MLS conversation between the current user and the user whose device is being viewed - CoreCrypto requires an MLS group to look up E2EI identities.
The UI layer cannot distinguish between:
E2EI not activated for the device (should show "Not activated" status)
E2EI data unavailable due to no common MLS conversation (should hide E2EI info entirely)
Solution
Introduced a new failure type GetMLSClientIdentityResult.Failure.E2EINotAvailable that is returned specifically when StorageFailure.DataNotFound occurs. This allows the UI layer to distinguish between "E2EI not activated" and "E2EI data unavailable" scenarios and handle them appropriately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-20235
Issue
When viewing another user's device details, the E2EI certificate status incorrectly shows "Not activated" even when the other user has a valid E2EI certificate.
Cause
The
GetMLSClientIdentityUseCasereturns a generic failure whenStorageFailure.DataNotFoundis encountered. This error occurs when there is no common MLS conversation between the current user and the user whose device is being viewed - CoreCrypto requires an MLS group to look up E2EI identities.The UI layer cannot distinguish between:
Solution
Introduced a new failure type
GetMLSClientIdentityResult.Failure.E2EINotAvailablethat is returned specifically whenStorageFailure.DataNotFoundoccurs. This allows the UI layer to distinguish between "E2EI not activated" and "E2EI data unavailable" scenarios and handle them appropriately.