Skip to content

fix: e2ei identity certificate status (WPB-20235)#3840

Open
sbakhtiarov wants to merge 1 commit intodevelopfrom
fix/e2ei-certificate-status
Open

fix: e2ei identity certificate status (WPB-20235)#3840
sbakhtiarov wants to merge 1 commit intodevelopfrom
fix/e2ei-certificate-status

Conversation

@sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Feb 4, 2026

TaskWPB-20235 [Android] Other users certificate is not shown as valid while self user has proteus device registered

https://wearezeta.atlassian.net/browse/WPB-20235

Issue

When viewing another user's device details, the E2EI certificate status incorrectly shows "Not activated" even when the other user has a valid E2EI certificate.

Cause

The GetMLSClientIdentityUseCase returns a generic failure when StorageFailure.DataNotFound is encountered. This error occurs when there is no common MLS conversation between the current user and the user whose device is being viewed - CoreCrypto requires an MLS group to look up E2EI identities.

The UI layer cannot distinguish between:

  1. E2EI not activated for the device (should show "Not activated" status)
  2. E2EI data unavailable due to no common MLS conversation (should hide E2EI info entirely)

Solution

Introduced a new failure type GetMLSClientIdentityResult.Failure.E2EINotAvailable that is returned specifically when StorageFailure.DataNotFound occurs. This allows the UI layer to distinguish between "E2EI not activated" and "E2EI data unavailable" scenarios and handle them appropriately.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Test Results

0 tests   - 4 300   0 ✅  - 4 185   0s ⏱️ - 4m 43s
0 suites  -   723   0 💤  -   115 
0 files    -   723   0 ❌ ±    0 

Results for commit 1df18d6. ± Comparison against base commit 06393f2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

🐰 Bencher Report

Branchfix/e2ei-certificate-status
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
720.15 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
502,951.41 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,351,158.98 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,191.06 µs
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.58%. Comparing base (06393f2) to head (1df18d6).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3840      +/-   ##
===========================================
- Coverage    59.59%   59.58%   -0.01%     
===========================================
  Files         1898     1898              
  Lines        59279    59282       +3     
  Branches      6420     6421       +1     
===========================================
+ Hits         35325    35326       +1     
  Misses       21039    21039              
- Partials      2915     2917       +2     
Files with missing lines Coverage Δ
.../feature/e2ei/usecase/GetE2EICertificateUseCase.kt 89.47% <100.00%> (+1.97%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06393f2...1df18d6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants