refactor: replace usersharedprefs [WPB-23210]#3839
Open
MohamadJaara wants to merge 4 commits intodevelopfrom
Open
refactor: replace usersharedprefs [WPB-23210]#3839MohamadJaara wants to merge 4 commits intodevelopfrom
MohamadJaara wants to merge 4 commits intodevelopfrom
Conversation
… - pt1 (WPB-23210) (#3830) * refactor: implement userprefs dao as replacements of user configs impl. * add test * add test
…w sync migration mechanism - pt2 (WPB-23210) (#3833) * refactor: implement userprefs dao as replacements of user configs impl. * add test * add test * refactor: change to enums for a way to wrap all the configs * refactor: execute migration of local props and increase slow sync to have updated * fix detekt * fix detekt
* refactor: implement userprefs dao as replacements of user configs impl. * add test * add test * refactor: change to enums for a way to wrap all the configs * refactor: execute migration of local props and increase slow sync to have updated * fix detekt * refactor: remove UserPrefBuilder and create UserConfigStorage only during migration --------- Co-authored-by: yamilmedina <yamilmedina@users.noreply.github.com>
|
Contributor
Contributor
|
| Branch | epic/replace-usersharedprefs |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 695.17 µs |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 589,713.06 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,341,726.99 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 20,885.61 µs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
app startup time can suffer from having 2 shared pref files created at startup, and the user scoped one is not really needed and its data can be moved to the user DB improving startup time
PRs added
#3830
#3833
#3835
Solutions
remove the user scoped shared preferance and replace it with the UserPrefDAO that uses the database
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.