fix: do not close SFT 1on1 call when other user audio is not established [WPB-19591]#3838
Open
fix: do not close SFT 1on1 call when other user audio is not established [WPB-19591]#3838
Conversation
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
|
Contributor
Contributor
|
Bencher Report| Branch | fix/closing-sft-1on1-call-when-audio-not-established |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 697.22 µs |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 346,098.77 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,341,500.39 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 20,889.38 µs |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3838 +/- ##
========================================
Coverage 59.59% 59.59%
========================================
Files 1898 1898
Lines 59267 59260 -7
Branches 6418 6413 -5
========================================
- Hits 35318 35314 -4
Misses 21035 21035
+ Partials 2914 2911 -3
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
During SFT 1:1 call, when one of participants loses connection and their audio stops being established, the call is dropped.
Causes (Optional)
Some time ago, when having problems with leaving subconversations, we implemented some short-term solution by deleting subconversation instead of leaving it and also checking for the audio established value of another participant to determine whether it's still in the call and close the call otherwise. The original problem was already solved by implementing long-term solution to leaving the subconversation (solved removal key problem) and we applied that changes but only removed first part of the temporary fix from code in kalium, but the other (logic using audio established parameter) remained and it conflicts with recent changes that allow reconnection in the event of a short internet outage - because of that logic, when other person loses connection in SFT 1:1 call then the call is instantly closed. This happens as well when both users enable video at the same time - both then initiate changing the call to a video call and update MLS and there’s a moment for both when the other person doesn’t have audio established and because of this logic the call is closed in that moment.
Solutions
Removed that logic of checking for the other participant's audio established value, we already have the long-term solution implemented and when other participants leave a call then they just leave a subconversation safely so the same logic can be applied to Proteus and MLS regular and SFT 1:1 calls - close the call when participants list changes from 2 to 1. Thanks to that we can have "connecting" state on 1:1 calls as well and be able to reconnect in case of short internet outage and enable videos at the same time.
The whole logic of checking whether the app can use SFT in 1:1 calls and whether the given call is established 1:1 moved inside the
CallHelper.shouldEndSFTOneOnOneCallmethod so that the whole logic is in one place and it's a standalone ready-to-use method that doesn't require any other checks outside of it.Testing
Test Coverage (Optional)
How to Test
User 1 starts 1:1 SFT call, user 2 answers, user 2 loses internet connection for a couple of seconds and connects back.
User 1 starts 1:1 SFT call, user 2 answers, both enable video at the same time.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.