Skip to content

feat: implement bulk update for persistent WebSocket status [WPB-23228]#3836

Open
MohamadJaara wants to merge 1 commit intodevelopfrom
mo/force-ws-enabled-via-mdm
Open

feat: implement bulk update for persistent WebSocket status [WPB-23228]#3836
MohamadJaara wants to merge 1 commit intodevelopfrom
mo/force-ws-enabled-via-mdm

Conversation

@MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Feb 3, 2026

TaskWPB-23228 [Android] Enable customers to set "Websocket always on" via MDM and lock the setting for end users


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

implement bulk update for persistent WebSocket status

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Test Results

0 tests   - 4 300   0 ✅  - 4 185   0s ⏱️ - 5m 9s
0 suites  -   723   0 💤  -   115 
0 files    -   723   0 ❌ ±    0 

Results for commit 30091ea. ± Comparison against base commit df99ed0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

🐰 Bencher Report

Branchmo/force-ws-enabled-via-mdm
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
702.45 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
604,631.05 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,360,929.66 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,479.19 µs
🐰 View full continuous benchmarking report in Bencher

@datadog-wireapp
Copy link

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1 Test failed

kaliumLogicModuleShouldNotExposeEitherTypesInPublicAPI[jvm] from com.wire.kalium.logic.architecture.UseCaseRulesTest (Datadog) (Fix with Cursor)
java.lang.AssertionError: Either types should not be exposed in public API of :kalium:logic module. Found 1 violation(s):
  - Public class 'GlobalKaliumScope' in GlobalKaliumScope has function 'setAllPersistentWebSocketEnabled' returning Either: Either<StorageFailure, Unit>

java.lang.AssertionError: Either types should not be exposed in public API of :kalium:logic module. Found 1 violation(s):
  - Public class 'GlobalKaliumScope' in GlobalKaliumScope has function 'setAllPersistentWebSocketEnabled' returning Either: Either<StorageFailure, Unit>

	at com.wire.kalium.logic.architecture.UseCaseRulesTest.kaliumLogicModuleShouldNotExposeEitherTypesInPublicAPI(UseCaseRulesTest.kt:165)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
...

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 30091ea | Docs | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant