Skip to content

fix: update last notified correctly (WPB-22701)#3823

Merged
sbakhtiarov merged 1 commit intodevelopfrom
fix/notifications-update
Feb 4, 2026
Merged

fix: update last notified correctly (WPB-22701)#3823
sbakhtiarov merged 1 commit intodevelopfrom
fix/notifications-update

Conversation

@sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Jan 27, 2026

BugWPB-22701 [Android] Not receiving all notifications

https://wearezeta.atlassian.net/browse/WPB-22701

What's new in this PR?

Issues

Application was not updating last_notified_date correctly. It was updated to the date of the last received message. Now application will pass the timestamp of the last notified message to be set as last_notified_date.

See wireapp/wire-android#4548 for more details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Test Results

0 tests   - 4 299   0 ✅  - 4 186   0s ⏱️ - 5m 11s
0 suites  -   723   0 💤  -   113 
0 files    -   723   0 ❌ ±    0 

Results for commit 4c02525. ± Comparison against base commit b185cfb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

🐰 Bencher Report

Branchfix/notifications-update
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
693.53 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
348,251.65 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,354,663.03 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
20,701.55 µs
🐰 View full continuous benchmarking report in Bencher

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 27, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4c02525 | Docs | Was this helpful? Give us feedback!

@sbakhtiarov sbakhtiarov force-pushed the fix/notifications-update branch from b1fcc87 to 4c02525 Compare January 28, 2026 09:21
@sonarqubecloud
Copy link

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.55%. Comparing base (b48b0fc) to head (4c02525).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...c/feature/message/MarkMessagesAsNotifiedUseCase.kt 63.63% 3 Missing and 1 partial ⚠️
...ersistence/dao/conversation/ConversationDAOImpl.kt 33.33% 1 Missing and 1 partial ⚠️
.../logic/data/conversation/ConversationRepository.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3823      +/-   ##
===========================================
- Coverage    59.55%   59.55%   -0.01%     
===========================================
  Files         1898     1898              
  Lines        59197    59209      +12     
  Branches      6417     6419       +2     
===========================================
+ Hits         35257    35263       +6     
- Misses       21027    21031       +4     
- Partials      2913     2915       +2     
Files with missing lines Coverage Δ
...um/persistence/dao/conversation/ConversationDAO.kt 90.00% <100.00%> (+0.52%) ⬆️
.../logic/data/conversation/ConversationRepository.kt 52.35% <50.00%> (+0.12%) ⬆️
...ersistence/dao/conversation/ConversationDAOImpl.kt 69.04% <33.33%> (-0.44%) ⬇️
...c/feature/message/MarkMessagesAsNotifiedUseCase.kt 77.77% <63.63%> (-22.23%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48b0fc...4c02525. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sbakhtiarov sbakhtiarov added this pull request to the merge queue Feb 4, 2026
Merged via the queue into develop with commit 06393f2 Feb 4, 2026
24 checks passed
@sbakhtiarov sbakhtiarov deleted the fix/notifications-update branch February 4, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants