fix: update last notified correctly (WPB-22701)#3823
Conversation
|
| Branch | fix/notifications-update |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 693.53 µs |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 348,251.65 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,354,663.03 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 20,701.55 µs |
b1fcc87 to
4c02525
Compare
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3823 +/- ##
===========================================
- Coverage 59.55% 59.55% -0.01%
===========================================
Files 1898 1898
Lines 59197 59209 +12
Branches 6417 6419 +2
===========================================
+ Hits 35257 35263 +6
- Misses 21027 21031 +4
- Partials 2913 2915 +2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|



https://wearezeta.atlassian.net/browse/WPB-22701
What's new in this PR?
Issues
Application was not updating last_notified_date correctly. It was updated to the date of the last received message. Now application will pass the timestamp of the last notified message to be set as last_notified_date.
See wireapp/wire-android#4548 for more details.