feat: add type safe message sync network dtos#3822
Open
MohamadJaara wants to merge 11 commits intoepic/shard-devicefrom
Open
feat: add type safe message sync network dtos#3822MohamadJaara wants to merge 11 commits intoepic/shard-devicefrom
MohamadJaara wants to merge 11 commits intoepic/shard-devicefrom
Conversation
Introduce MessageSyncContentDTO and MessageSyncPayloadDTO to replace the string-based payload in MessageSyncResultDTO and MessageSyncUpsertDTO. This provides type-safe serialization for text, asset, and location message content when syncing to the remote backup service.
Contributor
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 2531fd4. ♻️ This comment has been updated with latest results. |
Base automatically changed from
mo/remote-backup-database-ops
to
epic/shard-device
January 27, 2026 15:34
…work-dtos # Conflicts: # data/network-model/src/commonMain/kotlin/com/wire/kalium/network/api/authenticated/remoteBackup/MessageSyncResultDTO.kt # data/network-model/src/commonMain/kotlin/com/wire/kalium/network/api/authenticated/remoteBackup/MessageSyncUpsertDTO.kt
…ses in RemoteBackupApiV12Test
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## epic/shard-device #3822 +/- ##
====================================================
Coverage ? 59.70%
====================================================
Files ? 1915
Lines ? 59532
Branches ? 6431
====================================================
Hits ? 35541
Misses ? 21062
Partials ? 2929
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sbakhtiarov
approved these changes
Jan 29, 2026
| * This mirrors the structure of BackupMessageContent. | ||
| */ | ||
| @Serializable | ||
| sealed class RemoteBAckupMessageContentDTO { |
Contributor
There was a problem hiding this comment.
Looks like a typo in class name (uppercase A)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
add type safe message sync network dtos
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.