chore: remove wasm lib files after generating ts bindings#1822
Merged
Conversation
istankovic
reviewed
Feb 4, 2026
fewerner
force-pushed
the
felix/chore/remove-wasm-libfiles
branch
4 times, most recently
from
4fa93e7 to
30e7ff7
Compare
coriolinus
approved these changes
Feb 4, 2026
Keeping these files causes issues when running jvm-test or ios-test after ts bindings generation. It's cheap to regenerate them so we just remove them after bindings generation. We also change the execution order for `make local` to run ts since kotlin and swift use the same lib files.
fewerner
force-pushed
the
felix/chore/remove-wasm-libfiles
branch
from
30e7ff7 to
54f6768
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we remove lib files after ts bindings generation.
Keeping these files causes issues when running jvm-test or ios-test after ts bindings generation. It's cheap to regenerate them so we just remove them after bindings generation.
We also change the execution order for
make localto run ts since kotlin and swift use the same lib files.What's new in this PR
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.