Skip to content

feat: add kmp bindings#1705

Open
MohamadJaara wants to merge 2 commits intowireapp:mainfrom
MohamadJaara:mo/feat/v10/add-shared-kmp-and-jvm-module
Open

feat: add kmp bindings#1705
MohamadJaara wants to merge 2 commits intowireapp:mainfrom
MohamadJaara:mo/feat/v10/add-shared-kmp-and-jvm-module

Conversation

@MohamadJaara
Copy link
Member

What's new in this PR

  1. move the wrapper classes from jvm to a shared KMP module, this only required one change for the ByteArray.toHex() to use kotlin stdlib toHexString function
  2. add kmp bindings using gobley

PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara requested a review from a team December 22, 2025 10:03
@MohamadJaara MohamadJaara force-pushed the mo/feat/v10/add-shared-kmp-and-jvm-module branch 2 times, most recently from 53b6775 to 98c2d67 Compare January 9, 2026 08:58
@istankovic
Copy link
Member

@MohamadJaara could you please rebase this on top of latest main?

@MohamadJaara MohamadJaara force-pushed the mo/feat/v10/add-shared-kmp-and-jvm-module branch from 98c2d67 to 7a9f95d Compare January 23, 2026 11:13
@typfel
Copy link
Member

typfel commented Jan 28, 2026

After trying this out a bit more I realised the kmp build is re-building all the rust libraries via the cargo plugin in gradle. I'll try fix this as well so that it works with out build system and take advantage of our caching system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants