-
-
Notifications
You must be signed in to change notification settings - Fork 19
Lang copy dropdown improvements; updated Latvian translations #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Lang copy dropdown improvements; updated Latvian translations #109
Conversation
WalkthroughSeparated copy-specific CSS from shared button/dropdown styles, adjusted dropdown sizing/positioning, added translation keys for copy UI in English and Latvian, and added a translated dropdown title attribute in the locale copy partial. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks✅ Passed checks (5 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@arvislacis Rather than modifying the compiled CSS file, I believe it is preferable to modify the source file |
|
@damsfx Yeah, sorry, forgot about source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
assets/less/multilingual.less (1)
28-28: Verify width inconsistency between buttons and dropdown containers.The buttons (
.ml-btn,.ml-copy-btn) are set to 44px width via the.multilingual-button-style()mixin, while the dropdown containers (.ml-dropdown,.ml-copy-dropdown) are 42px width. Given that the button hasright: 1pxandposition: absolute(line 161), it extends further left than the dropdown positioned atright: 0, creating potential misalignment between these sibling elements.Confirm this width difference is intentional.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
assets/css/multilingual.cssassets/less/multilingual.less
🚧 Files skipped from review as they are similar to previous changes (1)
- assets/css/multilingual.css
🔇 Additional comments (2)
assets/less/multilingual.less (2)
165-165: LGTM – Hex color formatting improved.Lowercasing the hex color code improves consistency with CSS/Less conventions.
25-38: Excellent fix for the overlay issue.Removing
height: 100%from the base dropdown rules resolves issue #108 where the dropdown occupied full height even when hidden, blocking access to adjacent form controls. The specific height constraints (e.g.,height: 3pxat lines 69, 117) remain in place for contexts where minimal closed height is needed.
|
@damsfx Applied changes to source |
|
@LukeTowers @mjauvin Any feedback on this? |
This PR primary focuses on fixing #108 issue where language copy drop-down would overlap the repeater form fields which would then become inaccessible for editing.
Additional changes made:
P.S. Not related to this PR but I found out that copy language and multi-language switch looks a bit weird under CMS page management section (see the image below) so it should be fixed, improved later (probably in another PR):
Summary by CodeRabbit
New Features
Style
✏️ Tip: You can customize this high-level summary in your review settings.