-
-
Notifications
You must be signed in to change notification settings - Fork 19
Adding the ability to use machine translation providers to the copy feature #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IsaiahPaget
wants to merge
4
commits into
wintercms:main
Choose a base branch
from
IsaiahPaget:wip-auto-translation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ed7ab05
Add auto-translation support with Google & DeepL providers
IsaiahPaget 00bc81b
Addressing feedback from AIC
IsaiahPaget 20ad5db
update config
IsaiahPaget af59e92
cleaning up the concept of 'standard' translation and renaming it to …
IsaiahPaget File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Verification inconclusive
Verify PHP version compatibility with Guzzle 7.10.
Guzzle 7.10 requires PHP >=7.2.5, but this package specifies
"php": ">=7.2". While this may work, there's a slight mismatch that could cause issues for environments running PHP 7.2.0-7.2.4.Consider updating the PHP requirement to align with Guzzle's constraint:
Alternatively, verify that PHP 7.2.0-7.2.4 support is not needed by running:
🏁 Script executed:
Length of output: 65
I'll search for the actual PHP requirements for Guzzle 7.10 to verify the claim in the review comment.
Update PHP requirement to match Guzzle 7.10 dependency.
Guzzle 7.10.0 requires
php: ^7.2.5 || ^8.0, butcomposer.jsonspecifies"php": ">=7.2". Update the PHP requirement to prevent installation issues on PHP 7.2.0-7.2.4:🤖 Prompt for AI Agents