feat(config): add redirectStatus option #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a `redirectStatus` config option to set the HTTP status code for redirects managed by the plugin. Redirects now use the value from config instead of the default 302, allowing for more flexible redirect behavior.
Member
|
Thanks @matteotrubini, nice addition! |
LukeTowers
reviewed
Jul 22, 2025
| | | ||
| */ | ||
|
|
||
| 'redirectStatus' => env('TRANSLATE_REDIRECT_STATUS', 302), |
Member
There was a problem hiding this comment.
Thoughts on having this be a property of the component instead of a config item?
Contributor
Author
There was a problem hiding this comment.
Logically, I believe this is a general configuration applicable to all possible redirects managed by the plugin, even if at the moment they exist only in one component. It can also be used by plugin extensions, for example.
Anyway, I think it could be a good idea to provide an optional property with default value coming from the configuration to allow maximum flexibility.
In that case, prefixDefaultLocale should be configured in the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a
redirectStatusconfig option to set the HTTP status code for redirects managed by the plugin. Redirects now use the value from config instead of the default 302, allowing for more flexible redirect behavior.