-
-
Notifications
You must be signed in to change notification settings - Fork 227
Improve docs for checking for the correct Form widget instance #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just a thought - should we even call the |
How would that work exactly? The user would get the nested/repeater widgets from the main formWidget and extend its fields directly ? |
That seems like a can of worms I don't want to open. |
|
This requirement for checking |
|
The problem is how people are attaching the listener. The global event fires at all times on all instances of a Form widget and it must stay that way regardless of whether or not a Form instance is nested. It is already standard practice to check for the model class match, the controller class match, and the isNested call. I would recommend that we just provide a better example in the code example section rather than having a separate call out specifically for the isNested property. |
|
Done @LukeTowers |
|
@bennothommo @LukeTowers should that be moved to 1.2.2 since it has been merged already? |
No description provided.