Skip to content

Conversation

@jaxwilko
Copy link
Member

Added fix to ensure multiple assets are included in combination url.

Reported by @mjauvin

Test case:

{% set styleAssets = [
  'assets/css/test1.css',
  'assets/css/test2.css',
] %}

<link rel="stylesheet" href="{{ styleAssets | theme }}">

Result, only the first file was included.

@what-the-diff
Copy link

what-the-diff bot commented Mar 28, 2023

PR Summary

  • 📝 Refined break statement in Controller
    A minor update made to improve code consistency.
  • 🧪 New test case for themeCombineAssets()
    A new test ensures that URL generation, cache key extraction, and config decoding work correctly when combining multiple asset files into a single bundle using OctoberCMS framework's combiner library. This also checks that input and output file names remain the same.

@bennothommo bennothommo added Status: Completed maintenance PRs that fix bugs, are translation changes or make only minor changes labels Mar 29, 2023
@bennothommo bennothommo added this to the v1.2.2 milestone Mar 29, 2023
@bennothommo bennothommo merged commit 9294d39 into develop Mar 29, 2023
@bennothommo bennothommo deleted the fix/combining-multiple-assets branch March 29, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants