Skip to content

Fixed JS error in IconPicker FormWidget #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LukeTowers merged 1 commit into from
Mar 14, 2023
Merged

Fixed JS error in IconPicker FormWidget #867

LukeTowers merged 1 commit into from
Mar 14, 2023

Conversation

@xitara
Copy link
Contributor

@xitara xitara commented Mar 14, 2023

fix #826

@what-the-diff
Copy link

what-the-diff bot commented Mar 14, 2023

  • Added a new config option for the event handler.
  • Changed how we request data from the server to use this new config option instead of hardcoding it in JS code.

@xitara
Copy link
Contributor Author

xitara commented Mar 14, 2023

@LukeTowers
I killed my dev and my fork :( , so I had to fork again and send an new pull request with your suggestions and with the compiled javascript

@LukeTowers LukeTowers added this to the v1.2.2 milestone Mar 14, 2023
@LukeTowers LukeTowers added Status: Completed maintenance PRs that fix bugs, are translation changes or make only minor changes labels Mar 14, 2023
@LukeTowers LukeTowers changed the title fix javascript error in iconpicker Fixed JS error in IconPicker FormWidget Mar 14, 2023
@LukeTowers LukeTowers merged commit 5087713 into wintercms:develop Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukeTowers LukeTowers LukeTowers approved these changes

Assignees

No one assigned

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Milestone

v1.2.2

Development

Successfully merging this pull request may close these issues.

Error Iconpicker

2 participants

@xitara @LukeTowers