Skip to content

Improve French translations #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mjauvin merged 2 commits into from
Feb 28, 2023
Merged

Improve French translations #849

mjauvin merged 2 commits into from
Feb 28, 2023

Conversation

@damsfx
Copy link
Contributor

@damsfx damsfx commented Feb 28, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Feb 28, 2023

  • Add a new translation key for the error message when an invalid value is returned by static options method.
  • Update French translations of existing keys in backend and system modules, including:
    • "invalid_type" => 'Type de champ invalide :type.', (backend)
    • "options_method_not_exists" => 'La classe du modèle :model doit définir une méthode :method() renvoyant des options pour le champ ":field" du formulaire.', (backend)

@mjauvin mjauvin self-requested a review February 28, 2023 14:51
@mjauvin mjauvin self-assigned this Feb 28, 2023
@mjauvin mjauvin added maintenance PRs that fix bugs, are translation changes or make only minor changes accepted Issues that have been accepted by the maintainers for inclusion labels Feb 28, 2023
@mjauvin mjauvin added this to the v1.2.2 milestone Feb 28, 2023
@mjauvin mjauvin removed their request for review February 28, 2023 14:51
mjauvin
mjauvin requested changes Feb 28, 2023
View reviewed changes
Copy link
Member

@mjauvin mjauvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address these.

@mjauvin mjauvin added Status: Revision Needed and removed accepted Issues that have been accepted by the maintainers for inclusion labels Feb 28, 2023
damsfx
damsfx commented Feb 28, 2023
View reviewed changes
modules/backend/lang/fr/lang.php
'label' => 'Base de données introuvable',
'help' => 'Une base de données est requise pour l\'accès à l\'interface d\'administration. Veuillez vérifier que la base de données existe et que les migrations ont été effectuées avant de réessayer.',
'cms_link' => 'Retour à l\'accueil'
],
Copy link
Contributor Author

@damsfx damsfx Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjauvin Why do you want to add this entry?
It doesn't exist in the EN file.

@mjauvin
Copy link
Member

mjauvin commented Feb 28, 2023

Sorry @damsfx, I was looking in the wrong file...

@mjauvin mjauvin self-requested a review February 28, 2023 15:50
@mjauvin mjauvin added accepted Issues that have been accepted by the maintainers for inclusion and removed Status: Revision Needed labels Feb 28, 2023
@mjauvin
Copy link
Member

mjauvin commented Feb 28, 2023

Thanks @damsfx !

@mjauvin mjauvin merged commit caf1c77 into wintercms:develop Feb 28, 2023
@LukeTowers LukeTowers added Status: Completed and removed accepted Issues that have been accepted by the maintainers for inclusion labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjauvin mjauvin Awaiting requested review from mjauvin

Assignees

@mjauvin mjauvin

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Milestone

v1.2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@damsfx @mjauvin @LukeTowers