Skip to content

Conversation

@WebVPF
Copy link
Contributor

@WebVPF WebVPF commented Feb 27, 2023

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Feb 27, 2023

  • Исправлены типографические ошибки.
  • Во 2-м удалять -> удалять, 3-м - "не" -> "".
  • 4-5: 'saved' => '...', 5: ...-> "...'.

@LukeTowers
Copy link
Member

Thanks as always @WebVPF! If you have the time, do you mind adding a comment in the Files Changed tab to each line explaining what you changed and why?

I'm fine merging this without that, but I'm genuinely curious to learn more about the type of minor issues that show up in the other languages provided by Winter and the thought process behind picking one translation vs another. Let me know if that's something you could do or if I should just merge this regardless :)

@LukeTowers LukeTowers added needs response Issues/PRs where a maintainer is awaiting a response from the submitter maintenance PRs that fix bugs, are translation changes or make only minor changes labels Feb 27, 2023
@WebVPF
Copy link
Contributor Author

WebVPF commented Feb 28, 2023

@LukeTowers PR mainly corrects machine translation. There are no new values.

  • There are fixes for mistranslation
  • There are fixes for incorrect punctuation where I removed the comma.
  • There are fixes where machine translation messed up word order.
  • In Russian, there are letters e and ё. They are alike. For a long time there was a problem due to which the letter e was used instead of ё in computer typing. This problem has not been relevant for a long time. But in machine translation (Google translator), the letter ё is not used in the results. I've edited it to make it easier to read. Now more friendly interface.

@bennothommo bennothommo merged commit b1d28d9 into wintercms:develop Feb 28, 2023
@bennothommo bennothommo added this to the v1.2.2 milestone Feb 28, 2023
@bennothommo bennothommo added Status: Completed and removed needs response Issues/PRs where a maintainer is awaiting a response from the submitter labels Feb 28, 2023
@LukeTowers
Copy link
Member

Thanks for the insight @WebVPF, it's appreciated as always :) ❤️

@WebVPF WebVPF deleted the langru branch February 28, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants