[Draft] Fix #578 #598
Closed
[Draft] Fix #578 #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
LukeTowers
added a commit
that referenced
this pull request
Jul 10, 2022
…ig macros. This fixes #578 by adding the ability to pass the CMS Controller instance to the CMS Twig Extension removing the reliance on context variables as well as making the expected "global" twig variables inside of the CMS Twig environment actually global within that environment. Replaces #598 & #593. Credit to @RomainMazB for the initial implementation.
Member
|
Replaced by 5b8d189, thanks for your help @RomainMazB! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my first attempt to fix #578 without reintroducing a global context.
Two concerns here disturb me:
MacroTokenParserclass is final so we need to rewrite the full classcontrollerproperty inside the Twig cmsExtensionclass, but without this, I can't get any reference of the currently running controller to retrieve the controller context's variable, so afaik we need to reintroduce it. I created a methodsetControllerto bind the controller to the extension.