[Fix] 1.2 - PluginManager Normalization #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM 👍🏻 |
bennothommo
reviewed
Jun 29, 2022
bennothommo
added
Status: Completed
maintenance
LukeTowers
added a commit
that referenced
this pull request
Jun 29, 2022
* wip/1.2: (21 commits) Added fix to ensure correct normalization and return (#588) Outputs time respecting backend preferences (#572) Bump minimum Laravel version to 9.1 Fix site relative partial paths failing in 1.2 (#587) Switch back to using Laravel CacheServiceProvider Rebuild Snowboard agian Revert "Rebuild Snowboard" Rebuild Snowboard Allow a string selector for the form in a request Allow a string selector for the form in a request Use correct line breaks for Windows tests Backport ViewMaker tests from 1.2 branch Add additional testMakePartial cases to ViewMaker unit tests (#586) Added replaced plugins to the normalize map to ensure classloader namespace aliasing detects replacements (#585) Split tests into relevant module folders [FIX] Fix plugin flags not loading from cache correctly (#582) farsi spelling correction (#579) Moved plugin replacement namespace aliasing into register replacement method (#580) fix typo Add Winter 1.2 as version option in bug report ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #569
This PR updates the
PluginManagerto ensure that when callinggetNormalizedIdentifierornormalizeIdentifierthe input is returned if the not found in the normalize map.Also as these methods were performing similar functions, and internally calling each other, I've updated
normalizeIdentifierto callgetNormalizedIdentifierand act as an alias.I've added tests to ensure we do not run into regressions in the future.