Skip to content

[WIP] MediaManager ImageResizer #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukeTowers merged 14 commits into from
Jun 29, 2022
Merged

[WIP] MediaManager ImageResizer #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bd9047f
Added type hint
jaxwilko Jun 17, 2022
4c9c54f
Updated typehint in docblock
jaxwilko Jun 17, 2022
e8e88b8
Added make helper and implemented crop support
jaxwilko Jun 17, 2022
319cb90
Reworked thumbnail and cropping to use the ImageResizer
jaxwilko Jun 17, 2022
97ed762
Removed whitespace
jaxwilko Jun 17, 2022
fbf176c
Code review and sanity check
LukeTowers Jun 23, 2022
4e7bb7a
Code review
LukeTowers Jun 23, 2022
77ffb6a
Clean up path deduplication
LukeTowers Jun 23, 2022
686b934
Added fix for resizing image
jaxwilko Jun 26, 2022
59970b9
Exposed methods for accessing the resized disk
jaxwilko Jun 29, 2022
f79f2cb
Fixed support for cropping from a resized image
jaxwilko Jun 29, 2022
1449146
Code style fix
jaxwilko Jun 29, 2022
e3c8f29
Merge branch 'wip/1.2' into wip/1.2-media-resizer
LukeTowers Jun 29, 2022
397a556
Simplify path generation logic
LukeTowers Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/backend/traits/SessionMaker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ trait SessionMaker
/**
* Saves a widget related key/value pair in to session data.
* @param string $key Unique key for the data store.
* @param string $value The value to store.
* @param mixed $value The value to store.
* @return void
*/
protected function putSession($key, $value)
Expand Down
Loading