Multiple file attachments in theme customization #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR add a `multiple` property to fields in [theme customization](https://wintercms.com/docs/themes/development#customization). If `multiple: true`, the field is added to `attachMany` and allow multiple files selection, in all other cases the current behavior applied.
bennothommo
added
the
maintenance
bennothommo
approved these changes
Mar 15, 2022
LukeTowers
reviewed
Mar 15, 2022
Member
|
Looks good, just would like a minor formatting change done. Could you also submit a PR to the docs repo for the https://wintercms.com/docs/themes/development#customization section documenting the use of the multiple flag to indicate an attachMany relationship? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a
multipleproperty to fields in theme customization.If
multiple: true, the field is added toattachManyand allow multiple files selection, in all other cases the current behavior applied.