Skip to content

Convert afterFetch() method to an event handler for model.afterFetch #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjauvin wants to merge 3 commits into from
Closed

Convert afterFetch() method to an event handler for model.afterFetch #494

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9953227
comvert afterFetch method to an event handler for model.afterFetch
mjauvin Mar 14, 2022
5e25950
use afterBoot() hook instead
mjauvin Mar 14, 2022
c32e8cc
move comment to a more appropriate location
mjauvin Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions modules/cms/models/ThemeData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ class ThemeData extends Model
*/
protected static $instances = [];

/**
* after the model is booted, bind to 'model.afterFetch' event
*/
public function afterBoot()
{
$this->bindEvent('model.afterFetch', [$this, 'afterFetchHandler']);
}

/**
* Before saving the model, strip dynamic attributes applied from config.
* @return void
Expand Down Expand Up @@ -109,18 +117,18 @@ public static function forTheme($theme)
* on form field definitions.
* @return void
*/
public function afterFetch()
protected function afterFetchHandler()
{
$data = (array) $this->data + $this->getDefaultValues();

/*
* Repeater form fields store arrays and must be jsonable.
*/
foreach ($this->getFormFields() as $id => $field) {
if (!isset($field['type'])) {
continue;
}

/*
* Repeater form fields store arrays and must be jsonable.
*/
if ($field['type'] === 'repeater') {
$this->jsonable[] = $id;
}
Expand Down