Skip to content

Update settings.json #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LukeTowers merged 3 commits into from
Apr 21, 2022
Merged

Update settings.json #453

LukeTowers merged 3 commits into from
Apr 21, 2022

Conversation

@WebVPF
Copy link
Contributor

@WebVPF WebVPF commented Feb 16, 2022 •
edited by gitpod-io bot
Loading

components/partials/file.htm ===>

winter/.vscode/settings.json

Line 14 in 21e6783

"**/plugins/*/*/components/*/*.htm": "wintercms-twig",

This rule applies to components/partials/folder/file.htm

Question

Tell me, is there an ini block in the component partials files?

description = "qwerty"
==
<p>Partial content</p>

@WebVPF
Update settings.json
5990ebb 
`components/partials/file.htm` ===> https://github.com/wintercms/winter/blob/21e6783165a487df9933c3e7da2dfc8a64f2bf6a/.vscode/settings.json#L14

This rule applies to `components/partials/folder/file.htm`
LukeTowers
LukeTowers reviewed Feb 19, 2022
View reviewed changes
@LukeTowers LukeTowers changed the base branch from develop to wip/1.2 February 19, 2022 22:06
@LukeTowers LukeTowers added Status: Completed maintenance PRs that fix bugs, are translation changes or make only minor changes labels Feb 19, 2022
@LukeTowers LukeTowers added this to the v1.2.0 milestone Feb 19, 2022
@github-actions
Copy link

github-actions bot commented Apr 21, 2022

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@github-actions github-actions bot added the stale Issues/PRs that have had no activity and may be archived label Apr 21, 2022
@LukeTowers LukeTowers changed the base branch from wip/1.2 to develop April 21, 2022 05:28
@LukeTowers LukeTowers changed the base branch from develop to wip/1.2 April 21, 2022 05:28
@LukeTowers LukeTowers removed the stale Issues/PRs that have had no activity and may be archived label Apr 21, 2022
@LukeTowers LukeTowers merged commit 65e19d9 into wintercms:wip/1.2 Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukeTowers LukeTowers LukeTowers approved these changes

Assignees

No one assigned

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@WebVPF @LukeTowers