Skip to content

Improved Russian translation #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bennothommo merged 1 commit into from
Jan 28, 2022
Merged

Improved Russian translation #422

bennothommo merged 1 commit into from
Jan 28, 2022

Conversation

@WebVPF
Copy link
Contributor

@WebVPF WebVPF commented Jan 26, 2022

No description provided.

@WebVPF
Copy link
Contributor Author

WebVPF commented Jan 27, 2022 •
edited
Loading

Changing translation of "layout" word in Russian: octobercms/october#5291

@bennothommo bennothommo added needs response Issues/PRs where a maintainer is awaiting a response from the submitter maintenance PRs that fix bugs, are translation changes or make only minor changes labels Jan 27, 2022
@bennothommo
Copy link
Member

bennothommo commented Jan 27, 2022

@WebVPF just out of curiousity, what is the specific reason for changing "Content" and "Assets" back to English?

@WebVPF
Copy link
Contributor Author

WebVPF commented Jan 28, 2022

To avoid misleading users.
It is better to leave the original folder names from the English language for these menu items. Translation into Russian only makes things worse.
In Oсtober 2 the problem with naming was solved by removing the menu by making the folder-file structure.

This is not a spontaneous decision to change to English. This has been discussed many times before in the Russian-speaking community of October (even before the fork).

Until the release is released, I decided to fix it.

@bennothommo
Copy link
Member

bennothommo commented Jan 28, 2022

Alright - I'll merge this then, but will leave a note in the commit linking to your comment, given that there is the possibility that someone else may see this as an untranslated string in the future and submit a PR to translate them back.

@bennothommo bennothommo added Status: Completed and removed needs response Issues/PRs where a maintainer is awaiting a response from the submitter labels Jan 28, 2022
@bennothommo bennothommo added this to the v1.1.8 milestone Jan 28, 2022
@bennothommo bennothommo merged commit acbcd44 into wintercms:develop Jan 28, 2022
LukeTowers pushed a commit to wintercms/wn-backend-module that referenced this pull request Jan 31, 2022
@WebVPF
Improved Russian translation (#422)
2b2b82d 
It has been recommended that the menu items be kept in English for now, as per @WebVPF's [comment](wintercms/winter#422 (comment)). We'll need to revisit this later if we change the UI.
LukeTowers pushed a commit to wintercms/wn-cms-module that referenced this pull request Jan 31, 2022
@WebVPF
Improved Russian translation (#422)
99e09ed 
It has been recommended that the menu items be kept in English for now, as per @WebVPF's [comment](wintercms/winter#422 (comment)). We'll need to revisit this later if we change the UI.
LukeTowers added a commit that referenced this pull request Feb 8, 2022
@LukeTowers
Merge branch 'develop' into wip/snowboard
95c1d9f 
* develop: (25 commits)
  Use the asset helper for static assets
  Added asset filter & function versions of all System Twig filters (#428)
  Improve Japanese Translation (#435)
  Improved Latvian translation (#434)
  Improved Ukrainian translation (#433)
  Redirect to the myaccount page as a final fallback
  Improve Persian translations (#423)
  typo fix (#424)
  Improved Russian translation (#422)
  Tidy up
  Style fix
  Go to User's details page when clicking on related user from the roles update page
  Update recommend format for implementing controller behaviors
  Add support for default configuration file names for controller behaviors
  Attach default permissions to the publisher role
  Only show role user management in the update context
  Improve UserRole editing experience
  Fix support for readOnly on the datepicker formwidget.
  Sort assets alphabetically in the CMS Theme Editor (#420)
  VSCode recommended extensions (#417)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Milestone

v1.1.8

Development

Successfully merging this pull request may close these issues.

2 participants

@WebVPF @bennothommo