Skip to content

VSCode recommended extensions #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LukeTowers merged 2 commits into from
Jan 26, 2022
Merged

VSCode recommended extensions #417

LukeTowers merged 2 commits into from
Jan 26, 2022

Conversation

@WebVPF
Copy link
Contributor

@WebVPF WebVPF commented Jan 22, 2022 •
edited by gitpod-io bot
Loading

LukeTowers
LukeTowers reviewed Jan 22, 2022
View reviewed changes
@LukeTowers
Copy link
Member

LukeTowers commented Jan 23, 2022

I'd feel more comfortable about doing this if the extension was a codebase we controlled under the Winter CMS organization, @bennothommo any thoughts?

@WebVPF
Copy link
Contributor Author

WebVPF commented Jan 23, 2022

This entry does not require the mandatory installation of the extension. It just pops up once, which is recommended. Once when opening a project for the first time. Unobtrusively.
The extension will also be visible in the recommended extensions block.

If this extension is already installed in VSCode, then there will be no messages.

In the language association for some files, we have indicated wintercms. I think it's a good idea to recommend an extension that works with the wintercms language (ini, php, twig in one file).

@bennothommo
Copy link
Member

bennothommo commented Jan 23, 2022

@LukeTowers @WebVPF personally, I would prefer we keep this sort of config out of the main repo, as it's clutter for people who don't use VSCode... however, this will be handy for Gitpod.

@LukeTowers LukeTowers added Status: Completed maintenance PRs that fix bugs, are translation changes or make only minor changes labels Jan 26, 2022
@LukeTowers LukeTowers added this to the v1.1.8 milestone Jan 26, 2022
@LukeTowers LukeTowers merged commit 9b9a1bc into wintercms:develop Jan 26, 2022
LukeTowers added a commit that referenced this pull request Jan 26, 2022
@LukeTowers
Merge branch 'develop' of github.com:wintercms/winter into develop
ed775a3 
* 'develop' of github.com:wintercms/winter:
  Sort assets alphabetically in the CMS Theme Editor (#420)
  VSCode recommended extensions (#417)
  Altered order of operations to ensure modules are seeded before plugins (#419)
LukeTowers added a commit that referenced this pull request Feb 8, 2022
@LukeTowers
Merge branch 'develop' into wip/snowboard
95c1d9f 
* develop: (25 commits)
  Use the asset helper for static assets
  Added asset filter & function versions of all System Twig filters (#428)
  Improve Japanese Translation (#435)
  Improved Latvian translation (#434)
  Improved Ukrainian translation (#433)
  Redirect to the myaccount page as a final fallback
  Improve Persian translations (#423)
  typo fix (#424)
  Improved Russian translation (#422)
  Tidy up
  Style fix
  Go to User's details page when clicking on related user from the roles update page
  Update recommend format for implementing controller behaviors
  Add support for default configuration file names for controller behaviors
  Attach default permissions to the publisher role
  Only show role user management in the update context
  Improve UserRole editing experience
  Fix support for readOnly on the datepicker formwidget.
  Sort assets alphabetically in the CMS Theme Editor (#420)
  VSCode recommended extensions (#417)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukeTowers LukeTowers LukeTowers left review comments

Assignees

No one assigned

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Milestone

v1.1.8

Development

Successfully merging this pull request may close these issues.

3 participants

@WebVPF @LukeTowers @bennothommo