[Enhancement] Refactor winter:env, winter:install to use new EnvFile & ArrayFile parsers #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jaxwilko are these tests only failing because it's not pulling in the correct version of Storm? |
Member
|
@LukeTowers should be yes, storm can get merged first as it doesn't overwrite anything in use, then this branch should run the tests fine :) |
…es on future uses
# Conflicts: # modules/system/console/WinterEnv.php
This serves the dual purpose of both testing the output of the ArrayFile parser and normalizing the configs so that any future uses of ArrayFile on them will have easier to understand diffs.
These were generated by running the following in Tinker:
use Winter\Storm\Parse\PHP\ArrayFile;
$configPaths = glob(base_path('config/*'));
foreach ($configPaths as $path) {
if (is_file($path)) {
ArrayFile::open($path)->write();
}
}
LukeTowers
commented
Feb 17, 2022
LukeTowers
changed the title
Member
Author
|
Blocked by comments, especially the issue with the |
71 tasks
…nged lines on future uses" This reverts commit 897263e.
…inter into wip/config-write-replacement
This reverts commit c3bdfae.
# Conflicts: # config/app.php # config/auth.php # config/cms.php # config/database.php
Member
Author
|
Blocked by remaining TODO item and wintercms/storm#40 (comment) |
This will minimize changes when ConfigWriter is used to set config values through PHP.
LukeTowers
added
Status: Completed
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to wintercms/storm#40
TODO: