Remove redundant backend route #1258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjauvin
added
maintenance
Member
|
@mjauvin does this still work if backendUri is set to an empty string? |
Member
Author
Yes, that works too. |
bennothommo
reviewed
Nov 28, 2024
Co-authored-by: Ben Thomson <git@alfreido.com>
Member
Author
|
@LukeTowers care to merge this so we can test it in develop at a larger scale before we release 1.2.8 ? |
LukeTowers
removed
the
needs review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this on nginx and apache on both Laravel 9 and Laravel 11 by making sure the route cache was cleared.
No issues so far.