Added support for more detailed error logging #204
Conversation
|
Nice! |
|
@mjauvin ;)
|
Co-authored-by: Luke Towers <git@luketowers.ca> Related: wintercms/storm#204 This adds a fully backwards compatible "v2" log viewer that allows of unrolling of all previous exceptions. It also adds snippets for each frame in the call stack and extra information about the environment is recorded and displayed to the user. This is a stopgap solution until we get around to fully implementing the Ignition error page in Winter CMS core and displaying stored errors with that instead.
Co-authored-by: Luke Towers <git@luketowers.ca> Related: wintercms/storm#204 This adds a fully backwards compatible "v2" log viewer that allows of unrolling of all previous exceptions. It also adds snippets for each frame in the call stack and extra information about the environment is recorded and displayed to the user. This is a stopgap solution until we get around to fully implementing the Ignition error page in Winter CMS core and displaying stored errors with that instead.
Co-authored-by: Luke Towers <git@luketowers.ca> Related: wintercms/storm#204 This adds a fully backwards compatible "v2" log viewer that allows of unrolling of all previous exceptions. It also adds snippets for each frame in the call stack and extra information about the environment is recorded and displayed to the user. This is a stopgap solution until we get around to fully implementing the Ignition error page in Winter CMS core and displaying stored errors with that instead.
|
@jaxwilko @LukeTowers not sure if this was accounted for in this PR already, but it appears closures have more context now in a backtrace. See #203 (comment) for more info - it broke the relation name auto-guessing. Might be useful though for providing more context in the new backtraces. |
|
@bennothommo the issue is unless the
We get this trace:
If the php logic does pass the
The we would gain access to the object:
But we cannot 100% confirm that the While it would be really cool to add this logic, I'm not sure how we could extract the object reliably enough to consistantly generate the snippet (or even to display any extra data). |
This PR modifies how the details of an exeception are processed to allow us to display more information on the "Error Log" page.