Skip to content

Conversation

@mjauvin
Copy link
Member

@mjauvin mjauvin commented Dec 22, 2024

The following breaks HasRelationships concern:

$model->addDynamicMethod('myMethod', [static::class, 'myMethod']);

@mjauvin mjauvin added this to the 1.2.8 milestone Dec 22, 2024
@mjauvin mjauvin requested a review from bennothommo December 22, 2024 16:36
@mjauvin mjauvin self-assigned this Dec 22, 2024
@bennothommo
Copy link
Member

@mjauvin we will need a unit test to determine that a relation defined in the array callback format can be detected as a relation - your tests so far only seem to be "failure" states.

@mjauvin
Copy link
Member Author

mjauvin commented Dec 23, 2024

Yes, the tests so far are there to trigger the case that was failing before I made the PR.

@mjauvin
Copy link
Member Author

mjauvin commented Dec 23, 2024

@mjauvin we will need a unit test to determine that a relation defined in the array callback format can be detected as a relation - your tests so far only seem to be "failure" states.

Done!

@bennothommo bennothommo merged commit 91eaa7b into develop Dec 23, 2024
10 checks passed
@bennothommo bennothommo deleted the fix-dynamic-methods-relations branch December 23, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants