Initial WIP on improving the File model to use more native disk methods

[LukeTowers]

WIP

[what-the-diff]

• Added a constant DISK to the class.
• Changed fromPost and fromFile methods return type hinting static instead of void, also added nullable types for parameters in both functions.
• Removed unused setDataAttribute method as it is not used anywhere else in the codebase or called by any other classes/methods etc...
  5-6: Fixed typos within comments above each function where 'return' was spelt incorrectly as 'retunr'. This has since been fixed correctly now though :)

[github-actions]

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[mjauvin]

@LukeTowers has this been tested extensively?

[LukeTowers]

@mjauvin should be minimal impact, just requires the other PR that I'm finalizing right now for the metadata support

[mjauvin]

@mjauvin should be minimal impact, just requires the other PR that I'm finalizing right now for the metadata support

I would feel a lot more confident with some unit tests, this is used extensively in my projects

[LukeTowers]

@mjauvin see wintercms/winter@94ad5e8 for the changes required on the system module. These changes are relatively minor and should be non-breaking; but the changes in wintercms/winter#844 are going to need some more testing

[mjauvin]

@LukeTowers I get the following when updating to latest dev-develop:

In File.php line 48:
                                                                                                                                                              
  Declaration of System\Models\File::getPath($fileName = null) must be compatible with Winter\Storm\Database\Attach\File::getPath(?string $fileName = null):  
   string in /var/www/vhosts/wn.r4l.com/public_html/modules/system/models/File.php on line 48                                                                                                                                                     

Oh, never mind, I had not updated the system module...

[LukeTowers]

All good now @mjauvin?