Improve error message when Visual Studio can't be found#1691
Open
mitchhentges wants to merge 1 commit intowingtk:mainfrom
Open
Improve error message when Visual Studio can't be found#1691mitchhentges wants to merge 1 commit intowingtk:mainfrom
mitchhentges wants to merge 1 commit intowingtk:mainfrom
Conversation
mitchhentges
force-pushed
the
improve-vs-find-error
branch
2 times, most recently
from
a71f0db to
a1693d9
Compare
danyeaw
reviewed
Dec 20, 2025
Member
danyeaw
left a comment
danyeaw
left a comment
There was a problem hiding this comment.
Hey @mitchhentges - thanks for the contribution! I know our current test coverage isn't great, but would you mind adding a couple of tests to check that the updated logic is working correctly?
Contributor
Author
|
Good idea :) I've been thinking more about this, and I think I should bundle this "list of each ineligible VS installation" with the above "list of VS installations that will be checked". I'll do that wider change, then add some tests 👍 |
mitchhentges
force-pushed
the
improve-vs-find-error
branch
from
a1693d9 to
d04ee1b
Compare
This addresses the confusion of `gvsbuild` showing that it _found_ Visual Studio installations, but then logging right after that it couldn't, in fact, find it. This tweaks the list of detected VS installations to also include logs when an installation is considered "inapplicable", such as because: * The version doesn't match `vs_ver` * The `vcvars.bat` is missing
mitchhentges
force-pushed
the
improve-vs-find-error
branch
from
d04ee1b to
71a0150
Compare
Contributor
Author
|
I've still got tests to add, but here's how it looks when I've combined "failure reason" with "list of detected installations": Failure case: One failure but one usable installation case: 
I'll follow up with tests "soon" 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the confusion of
gvsbuildshowing that it found Visual Studio installations, but then logging right after that it couldn't, in fact, find it.This tweaks the list of detected VS installations to also include logs when an installation is considered "inapplicable", such as because:
vs_vervcvars.batis missing