Fix Firecrawl fallback: limit to bot-block responses, use 422 status#59
Merged
Fix Firecrawl fallback: limit to bot-block responses, use 422 status#59
Conversation
- Change site_blocked and fetch_failed HTTP status from 502 (BadGateway) to 422 (UnprocessableEntity) so client JSON parsing works correctly and errors don't collide with ALB-generated 502s - Log the actual Firecrawl error when fallback fails (was silently swallowed) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4feb1a6b5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fetch_failed represents transient upstream failures (500, 429, etc.) that may resolve on retry — 502 (BadGateway) is semantically correct. site_blocked is a permanent condition — 422 is appropriate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch_failederror for other non-200 statuses (500, 502, 429, 301, etc.) instead of misleadingsite_blockedsite_blockedandfetch_failederrors from 502 (BadGateway) to 422 (UnprocessableEntity) — avoids collision with ALB-generated 502s and fixes Dio JSON parsing on the clientisBotBlockStatushelper with table-driven testsTestExtractFromURL_500_NoFirecrawlto verify non-bot-block errors skip FirecrawlTest plan
go test ./... -count=1— all tests passTestExtractFromURL_403_*tests still route through FirecrawlTestExtractFromURL_500_NoFirecrawlreturnsfetch_failed, notsite_blockedTestIsBotBlockStatuscovers 200, 301, 400, 402, 403, 404, 429, 500, 502, 503TestPreviewFromURL_Handler_SiteBlockedupdated to expect 422🤖 Generated with Claude Code