Conversation
- Remove RecipeHistory/RecipeHistoryEntry system; regen/fork now use tree node ancestors for AI context via nodeChainToMessages() - Change Personalization.UnitSystem from int enum to string; remove Recipe.UnitSystem duplicate column and all enum helpers - Remove RecipeDef.Hashtags; thread hashtags separately through pipeline - Merge duplicate aiResultToRecipeDef into single recipeResultToRecipeDef - Extract effectiveRecipeDef() helper to DRY canonical resolution - Add Recipe.Status field (generating/ready/failed) for async tracking - Add composite index (created_by_id, created_at DESC) on recipes - Simplify UpdateRecipeDef to not require history entry parameter - Remove /recipes/chat-history/:history_id route - Remove MigrateRecipeHistoryToTree migration Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c3687c6ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add MetricUnit/MetricAmount fields to Ingredient structs across the full pipeline (models, AI tool schema, service layer, handlers). Update all 6 recipe prompts to instruct dual-unit generation. Add tests for metric field round-trip serialization and omitempty. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Personalization.UnitSystemis now a string ("us_customary"/"metric"); removed int enum,Recipe.UnitSystemduplicate column, and all enum helpersaiResultToRecipeDef()consolidated into singlerecipeResultToRecipeDef()effectiveRecipeDef()helper used in 3 places"generating"/"ready"/"failed"for async generation tracking(created_by_id, created_at DESC)on recipes tableNet: -552 lines (244 added, 796 removed)
Test plan
go test ./... -count=1— all tests pass🤖 Generated with Claude Code