Skip to content

optimize first-user check in create_profile to avoid full table scan#40

Open
ilikeworking2005 wants to merge 1 commit intowindoze95:mainfrom
ilikeworking2005:fix/inefficient-table-scan-in-create_profile-33
Open

optimize first-user check in create_profile to avoid full table scan#40
ilikeworking2005 wants to merge 1 commit intowindoze95:mainfrom
ilikeworking2005:fix/inefficient-table-scan-in-create_profile-33

Conversation

@ilikeworking2005
Copy link

Problem:
create_profile determines if a user is the first registrant by fetching every user from the database and checking len(existing) == 0. As the userbase grows this instantiates unnecessary ORM objects for every row wasting memory and database I/O.

Fix
Replace the full fetch with a LIMIT 1 query on User.id only the database stops after finding a single row making this effectively O(1) regardless of table size.

Before

result = await db.execute(select(User))
existing = result.scalars().all()
is_first_user = len(existing) == 0

After

result = await db.execute(select(User.id).limit(1))
is_first_user = result.scalar_one_or_none() is None
Impact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant