optimize first-user check in create_profile to avoid full table scan#40
Open
ilikeworking2005 wants to merge 1 commit intowindoze95:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
create_profile determines if a user is the first registrant by fetching every user from the database and checking len(existing) == 0. As the userbase grows this instantiates unnecessary ORM objects for every row wasting memory and database I/O.
Fix
Replace the full fetch with a LIMIT 1 query on User.id only the database stops after finding a single row making this effectively O(1) regardless of table size.
Before
result = await db.execute(select(User))
existing = result.scalars().all()
is_first_user = len(existing) == 0
After
result = await db.execute(select(User.id).limit(1))
is_first_user = result.scalar_one_or_none() is None
Impact