Conversation
winderdoot
left a comment
winderdoot
left a comment
There was a problem hiding this comment.
Also this pr messes up the branch history in some weird way. I will do my best to fix it
| { | ||
| get => _role; | ||
| init => _role = value; | ||
| } |
There was a problem hiding this comment.
Nonono, I am using required fields here intentionally. Read up on the stuff I wrote in docs/guidelines.md. It's not fully finished yet, but tldr: we use required whenever possible, and then to allow initializing the field in an object initializer (new Class { field = value... };) we write { get; init; }. If we need internal modification on the field then we have to use a private backing field. Hence this boilerplate. I know it's more code but in my opition it's more robust and I intend to use this across the codebase.
| var errors = new List<FieldError>(); | ||
|
|
There was a problem hiding this comment.
This is good, we can keep this.
I will make a new commit, fixing the required fields
2 participants
No description provided.