Conversation
wilsonpage
force-pushed
the
90-version-compat
branch
from
a8145a4 to
c5caec2
Compare
|
@indianburger can you review this and see if it fixes your issues? |
|
@indianburger I need to write some unit-tests, but don't want to block you 😃 I've added a pretty detailed comment above the new conflict resolution code. It's late and I'm tired, so I could have easily missed something. |
|
@indianburger what's your status? Have you found a workaround or are you still interested in this fix? |
| var compatible = version === FastDom.prototype.version; | ||
| var exports = compatible ? existing : new FastDom(); | ||
| if (compatible) return existing; | ||
| console.warn('[fastdom] Multiple incompatible versions detected (this could impact performance)'); |
There was a problem hiding this comment.
How about adding a link to the issue in the warning?
|
Looks good and works for us. 👍🏾 |
|
Also to note, we hacked a version together to unblock us temporarily. So feel free to take a bit more time to add tests and do it proper. |
|
Cool. I'm on vacation for the next week. I'll be able to take a look next week. |
|
Start |
|
still on vacation? @wilsonpage |
5 participants
No description provided.