Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a configurable maximum user limit feature to librarySync. The system now enforces a cap on the number of registered users, preventing new registrations once the limit is reached.
Changes:
- Added
LIBRARYSYNC_MAX_USERSenvironment variable (default: 1) to control maximum allowed users - Implemented user count check in registration endpoint to enforce the limit
- Updated login page template to display appropriate message when user limit is reached
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.env.example |
Added LIBRARYSYNC_MAX_USERS=1 configuration variable |
backend/src/librarysync/config.py |
Added max_users setting to Settings class with default value of 1 |
backend/src/librarysync/api/routes_auth.py |
Added user count validation in register endpoint to enforce max_users limit |
backend/src/librarysync/main.py |
Added user count check in login route to determine if registration is full |
backend/src/librarysync/templates/login.html |
Updated template to show "Registration full" message when user limit reached |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.