Fix rest timer duplicate and missing notifications#27
Merged
Conversation
Two bugs fixed: 1. Race condition: async updateTimer callback could fire multiple times simultaneously when browser resumes from suspension, causing duplicate notifications. Added a guard flag to prevent re-entry. 2. Missing notification: when page re-renders and finds an already-expired timer, it was silently cleared without notifying. Now fires notification. https://claude.ai/code/session_01Fh28cVSx69AKfkhsNNKwMC
Tests verify: 1. Expired timer found on page re-render fires a notification (not silently cleared) 2. Timer expiry fires notification exactly once (no duplicates from race condition) https://claude.ai/code/session_01Fh28cVSx69AKfkhsNNKwMC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs fixed:
simultaneously when browser resumes from suspension, causing duplicate
notifications. Added a guard flag to prevent re-entry.
timer, it was silently cleared without notifying. Now fires notification.
https://claude.ai/code/session_01Fh28cVSx69AKfkhsNNKwMC