Skip to content

Improve error handling #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fenrir-naru wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve error handling #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ba24c5
Fix unwanted exit in nerror(); use rb_raise instead.
fenrir-naru Aug 5, 2016
6c22676
Add raise error for (m<n) condition
fenrir-naru Aug 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ext/nrutil.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ float *vector();
/* function definition */


#if 0
void nrerror(char error_text[])
/* Numerical Recipes standard error handler */
{
Expand All @@ -96,6 +97,7 @@ void nrerror(char error_text[])
fprintf(stderr, "...now exiting to system...\n");
exit(1);
}
#endif

float *vector(long nl, long nh)
/* allocate a float vector with subscript range v[nl..nr] */
Expand Down
9 changes: 8 additions & 1 deletion ext/svd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ VALUE decompose(VALUE module, VALUE matrix_ruby, VALUE m_ruby, VALUE n_ruby) {
/* precondition */
if((m*n) != RARRAY_LEN(matrix_ruby)) {
rb_raise(rb_eRangeError, "Size of the array is not equal to m * n");
return;
}else if(m<n){
rb_raise(rb_eRangeError, "m(%d) must be greater than or equal to n(%d)", m, n);
}

/* convert to u matrix */
Expand Down Expand Up @@ -64,3 +65,9 @@ void Init_svd()
VALUE module = rb_define_module("SVD");
rb_define_module_function(module, "decompose", decompose, 3);
}

void nrerror(char error_text[])
/* Numerical Recipes standard error handler */
{
rb_raise(rb_eRuntimeError, "Numerical Recipes run-time error...\n%s\n", error_text);
}