add transparent amd gpu support #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
this is early RFC. I added transparent AMD GPU support. I would be very happy about feedback :)
To build for amd, simply run
make TARGET=AMD. By default, it will still build for NVIDIA of course without any functional changes.Currently, gpu temp support is not available. While I have though about implementing the same pattern as taken with nvidia-smi, I don't think this is a clean solution. My take here would be to compile amdsmi as a static library and directly link against it. The licenses should be compatible, but correct me if I'm wrong. Also I haven't checked yet whether and how amdsmi handles global state, so there might be a technical issue.
Also I had to comment out some cublas functions. I do not know whether this leads to functional differences, so that should definitely be looked at.
Please let me know what you think :)