issue #151 -- preserve tombstones during merges and fix deletion sema…#154
Merged
issue #151 -- preserve tombstones during merges and fix deletion sema…#154
Conversation
…ntics ** add canDropTombstones to mergeSSTables; compute it in callers and preserve tombstones when overlapping SSTables exist ** fix Delete() to always create tombstone nodes (insert via CAS when key is missing from the skiplist) ** make tombstones visible: ** findVisibleVersion() now returns Delete versions ** Iterator.Next() yields deleted entries with nil data for the flusher ** include tombstone keys in SSTable metadata: ** add GetMinKey / GetMaxKey ** update flusher and EntryCount to account for tombstones ** update Go module dependencies ** corrected Windows race by waiting in ForceFlush() for in-progress background flushes to complete ** rid magic numbers, and strings from code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ntics
** add canDropTombstones to mergeSSTables; compute it in callers and preserve tombstones when overlapping SSTables exist ** fix Delete() to always create tombstone nodes (insert via CAS when key is missing from the skiplist) ** make tombstones visible:
** findVisibleVersion() now returns Delete versions
** Iterator.Next() yields deleted entries with nil data for the flusher
** include tombstone keys in SSTable metadata:
** add GetMinKey / GetMaxKey
** update flusher and EntryCount to account for tombstones
** update Go module dependencies
** corrected Windows race by waiting in ForceFlush() for in-progress background flushes to complete ** rid magic numbers, and strings from code