Extract table #187
Open
Extract table #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create TableLink component create userLink array in Profiles.tsx for utility map userLink returning TableLink.tsx
extract TableRow component and associated logic from Profiles.tsx
create component UserTable.tsx from Profiles.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abstracts UserTable component, TableUserRow component and TableLink component from Profiles.tsx
simple refactors for the 3 components, had to pass props to each component had to type: any some.
Related Issue
solves issue #13
Motivation and Context
some simple abstractions to increase the readability of Profiles, UserTable, TableUserRow and TableLink in preparation for updating table styles and functionality.
How Has This Been Tested?
I have manually tested these changes and no discernible changes from original code visible on website.
Types of changes
Checklist: