Skip to content

added accelerator keys#265

Open
aryan040501 wants to merge 4 commits intowikimedia:masterfrom
aryan040501:aryaman
Open

added accelerator keys#265
aryan040501 wants to merge 4 commits intowikimedia:masterfrom
aryan040501:aryaman

Conversation

@aryan040501
Copy link
Copy Markdown

I added the accelerator keys according to T162109

@aklapper
Copy link
Copy Markdown

Hi and thanks! Could you please resolve the errors in the patch? See the list at https://travis-ci.org/github/wikimedia/wikilabels/builds/753930294 - thanks a lot! :)

@aryan040501
Copy link
Copy Markdown
Author

aryan040501 commented Jan 15, 2021

I have made the required edits.

I also had a question - Do I need to communicate on phabricator to solve issues? or can I do it directly here also by commenting on the issue I want to work on?
I am new to open source, so it would be a great help to me
@aklapper

@aklapper
Copy link
Copy Markdown

Thanks! That's a good question for the Wikilabels folks (I'm not one of them). :)

@aryan040501
Copy link
Copy Markdown
Author

Thanks! That's a good question for the Wikilabels folks (I'm not one of them). :)

Oh! I am sorry I thought you were with Wikilabels.
Are you a mentor for wikilabels?

PS: will the PR be merged?

@aklapper
Copy link
Copy Markdown

Are you a mentor for wikilabels?

I am not. I'm with Wikimedia. :)

PS: will the PR be merged?

In general (applies to any PR in any project): First it needs to be reviewed. If the review is positive, then likely yes.

@aryan040501
Copy link
Copy Markdown
Author

Are you a mentor for wikilabels?

I am not. I'm with Wikimedia. :)

PS: will the PR be merged?

In general (applies to any PR in any project): First it needs to be reviewed. If the review is positive, then likely yes.

Oh, Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants