Add option to leave the menu open when clicking #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the ULS menu is closed when the user clicks an item, but that is not always desirable. This commit partially solves [T347846](https://phabricator.wikimedia.org/T347846); a follow-up commit in the ULS MediaWiki extension will do the rest.
Contributor
Author
|
The follow-up patch in the ULS extension is here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/1191736 |
Member
|
@jhsoby Thanks for the contribution! I just learned that there are major changes planned for this project, so this PR may not be applicable in its current form and is unlikely to receive attention. |
Contributor
Author
|
@srish Yeah, Niklas told me it is because of a planned rewrite of the ULS extension. While that's fine, this is such a tiny patch for a quality of life improvement, so it would be nice to get it merged. It would also help inform the rewrite effort about what expected behaviour should be, so we don't get a new version with the same bug replicated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the ULS menu is closed when the user clicks an item, but that is not always desirable.
This commit partially solves T347846; a follow-up commit in the ULS MediaWiki extension will do the rest.