Fix misleading convertNumber() call#123
Open
ricordisamoa wants to merge 1 commit intowikimedia:masterfrom
Open
Fix misleading convertNumber() call#123ricordisamoa wants to merge 1 commit intowikimedia:masterfrom
ricordisamoa wants to merge 1 commit intowikimedia:masterfrom
Conversation
The second argument should be a boolean, and the result already goes through parseFloat()
ricordisamoa
commented
Jan 12, 2017
| */ | ||
| plural: function ( nodes ) { | ||
| var count = parseFloat( this.language.convertNumber( nodes[ 0 ], 10 ) ), | ||
| var count = this.language.convertNumber( nodes[ 0 ], true ), |
Contributor
Author
There was a problem hiding this comment.
Do you want to keep parseFloat() just in case convertNumber() is overridden by a misbehaving implementation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second argument should be a boolean, and the result already goes through
parseFloat()