This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Open
Conversation
Author
|
The sha512 support is working on my system now. I also added a UI to select the hash algorithm for backward compatiblity and changed the default to sha512 and len 14. Feedback welcome and thanks for creating this extension in the first place. |
Author
|
The node cli part needs work as the password should obviously not passed via the commandline, that is just a proof-of-concept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a request for feedback, not yet a fully ready pull request.
It adds a nodejs cli mode to get the password (prototype only for now) and updates the code to prepare for using sha512 instead of sha1 (as its much harder to crack, some numbers in http://arstechnica.com/security/2013/05/how-crackers-make-minced-meat-out-of-your-passwords/).
If you aggree with the general direction I will continue and add a option to select the cypher and use sha1 only for backport compat.