[QOL] Add a game renaming feature

[Alex9303]

Adds a button to the game settings menu that allows the user to visually rename a game on the list.
This renaming feature is purely visual and does not modify any game files. Renamed games keep their new names across reboots.
I created this because I found memorizing the game's internal name annoying.
I would love to see this feature in release. If anything needs to be changed or reworked then please let me know.

[eku]

Wouldn't it be easier to edit wiitdb.xml in ULGX's app directory?

[Alex9303]

I don't have a wiitdb.xml file in usbloader_gx's app directory. Even when using the most recent version. I already assumed there was a way to rename games but there seems no user friendly option for average users like myself.
Yes, it probably would be easier to just edit an xml file but having the convenience doing it straight from the Wii wouldn't hurt would it?

[eku]

I don't have a wiitdb.xml file in usbloader_gx's app directory. Even when using the most recent version.

It's a feature from ULGX. There's even a menu entry to download the file from GameTDB and you'll get long game descritions and many more with the feature.

[wiidev]

The loader already has this feature, but it's basically deprecated as the option is only offered under an old display mode (rotating discs).

The way you've implemented renaming results in the custom title being saved to both TitlesCache.bin and GXGameSettings.cfg, which could easily get out of sync if you were to select the Reset All Game Settings option.

[Alex9303]

Thank you all for your inputs! I would love to see this feature become part of the app. Since there is already a way to rename games using wiitdb.xml then maybe my rename button could edit that file instead to prevent desync issues. I feel like having a button is much easier for normies like myself instead of having to eject the sd card to edit wiitdb.xml. My initial pull request was more of a proof of concept and I should have explained that better.

I feel like this would be a great quality of life feature. Here is my plan:

1. Undo code that writes to TitlesCache.bin.
2. Rework the code to modify GXGameSettings.cfg or wiitdb.xml (I am getting conflicting information about what file handles game names).
3. Prevent any desync when Reset All Game Settings.

Is there anything else I should change or do? Thank you!

[wiidev]

It's actually your modifications to GXGameSettings.cfg and the custom title loading that you've added that's unnecessary 😅

If you take a look at how the existing function works, you'll see that it uses TITLETYPE_MANUAL_OVERRIDE, which integrates with the caching system and stores custom titles in TitlesCache.bin. You can also test this in the current version of the loader by going to GUI Settings, setting Game Window Mode to Rotating Disc, and then clicking on a games title.

I haven't personally copied this option directly into the settings menu, since I usually recommend using WIT to permanently set a custom title and game ID for modified games. And the titles that WiiTDB provides are normally great, in my opinion.