-
Notifications
You must be signed in to change notification settings - Fork 0
Dependency updates + dev docs update #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughBumps CI Go setup to actions/setup-go@v6 and Go to 1.25.1, pins moq install to v0.6.0, updates developer docs to install moq and adjust PATH, upgrades example/my-app dependencies and module Go version, and applies two small internal formatting tweaks. Changes
Sequence Diagram(s)Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (3)
🧰 Additional context used📓 Path-based instructions (1)**/*.go📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🧠 Learnings (1)📚 Learning: 2025-07-28T17:26:16.526ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
+ Coverage 39.35% 39.36% +0.01%
==========================================
Files 194 194
Lines 39669 39669
==========================================
+ Hits 15612 15616 +4
+ Misses 23304 23300 -4
Partials 753 753 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/docs.yml (1)
24-24: Pin moq version consistently
Use the same fixed version (v0.6.0) in all install commands to avoid upstream breakages:
- .github/workflows/docs.yml:
go install github.com/matryer/moq@v0.6.0- dev/bootstrap.sh:
go install github.com/matryer/moq@v0.6.0
🧹 Nitpick comments (3)
.github/workflows/docs.yml (3)
21-22: Avoid mutating go.mod/go.sum in CI: replace/remove go get -d.go get -d can change module files; prefer go mod download or rely on build.
- - run: cd cmd/mkunion; go get -v -t -d ./... - run: cd cmd/mkunion; go build -o mkunion @@ - - run: go get -v -t -d ./... + - run: go mod downloadAlso applies to: 26-26
17-18: Enable module cache for faster runs.actions/setup-go supports caching; enable it here.
with: - go-version: ^1.25.1 + go-version: ^1.25.1 + cache: true
13-13: Optional: Pin GitHub Actions to commit SHAs.Improves supply‑chain security; keep major tag as a comment for readability.
Example:
- uses: actions/checkout@v5 + uses: actions/checkout@<commit-sha> # v5Apply similarly to setup-go and setup-python.
Also applies to: 16-16, 38-38
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
example/my-app/go.sumis excluded by!**/*.sum
📒 Files selected for processing (6)
.github/workflows/ci.yml(2 hunks).github/workflows/docs.yml(1 hunks)example/my-app/go.mod(2 hunks)go.mod(1 hunks)x/generators/shape_tagged.go(1 hunks)x/storage/predicate/where.go(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- go.mod
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/ci.yml
🧰 Additional context used
📓 Path-based instructions (1)
**/*.go
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.go: Use//go:tag mkunion:"UnionName"to mark types for union generation in Go source files
For generic unions, use//go:tag mkunion:"UnionName[T, E]"with explicit type parameters, and ensure type parameter names match between tag and variant types
The type registry can be disabled with//go:tag mkunion:",no-type-registry"in Go source files
UseMatchUnionNameR1()for exhaustive pattern matching with one return value in Go code
State machines should use union types for states and commands, with explicit dependencies defined in Go code
Transition functions for state machines should accept context, dependencies, command, and state as parameters and return the new state and error
Create state machine instances with explicit dependencies and optional initial state using a constructor function in Go code
Files:
x/generators/shape_tagged.gox/storage/predicate/where.go
🧠 Learnings (1)
📚 Learning: 2025-07-28T17:26:16.526Z
Learnt from: CR
PR: widmogrod/mkunion#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-28T17:26:16.526Z
Learning: Always run `mkunion watch -g ./...` to generate new files including go:generate tag
Applied to files:
.github/workflows/docs.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test implementation in Golang
🔇 Additional comments (4)
x/storage/predicate/where.go (1)
78-78: LGTM! Good security practice.Using an explicit format string
"%s"prevents the dynamic error message from being interpreted as a format string. This guards against potential issues if parameter names or predicates inadvertently contain format verbs.x/generators/shape_tagged.go (1)
341-341: LGTM! Nice cleanup.Removing the unnecessary
fmt.Sprintfwrapper makes the code more idiomatic and slightly more efficient by eliminating an intermediate string allocation..github/workflows/docs.yml (1)
16-19: Go/toolchain bump LGTM.actions/setup-go@v6 with go-version ^1.25.1 is good.
example/my-app/go.mod (1)
17-17: Rungo mod tidyand re-run tests. All aws-sdk-go-v2 entries in go.mod are indirect and no direct imports were found.
…sions - Bumped versions for multiple `github.com/aws/aws-sdk-go-v2` modules, including `v1.39.2`, `service/dynamodb v1.50.5`, `service/sqs v1.42.8`, and others for compatibility and improvements.
…encies - Upgraded several `github.com/aws/aws-sdk-go-v2` modules, including `v1.39.2`, `service/dynamodb v1.50.5`, `service/sqs v1.42.8`, and others for improvements and compatibility. - Removed unused `fatih/structtag` dependency.
a1dfa4d to
13f9417
Compare
Summary by CodeRabbit
Documentation
Chores