Skip to content

Conversation

@darthnall
Copy link
Contributor

The current implementation of flags.py has variable names that are not intuitive to me. I renamed most of the flags, finished inputting most of the missing flags from the original implementation, and provided Wialon API reference links near the relevant entries.

Flags are named following these patterns:

  • FLAGTYPE_OBJECT_ACTION
  • FLAGTYPE_ACTION (Generic flags)

I would love to hear feedback on this naming scheme; I believe with modern IDEs/text editor extensions, this naming scheme makes it simpler to find the specific flag I'm looking for while working with the Wialon API in Python.

I would appreciate an extra pair of eyes on the Wialon API reference double-checking the values for these flags, I want to make sure the values on the reference and flags_v2.py are consistent and I didn't miss anything.

I expect this module to be used like this:

>>> from wialon import flags_v2 as flag
>>> flag.ACCESSFLAG_VIEW_ITEM_DETAILED
2

@darthnall darthnall marked this pull request as ready for review September 13, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant