Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
flags.pyhas variable names that are not intuitive to me. I renamed most of the flags, finished inputting most of the missing flags from the original implementation, and provided Wialon API reference links near the relevant entries.Flags are named following these patterns:
FLAGTYPE_OBJECT_ACTIONFLAGTYPE_ACTION(Generic flags)I would love to hear feedback on this naming scheme; I believe with modern IDEs/text editor extensions, this naming scheme makes it simpler to find the specific flag I'm looking for while working with the Wialon API in Python.
I would appreciate an extra pair of eyes on the Wialon API reference double-checking the values for these flags, I want to make sure the values on the reference and
flags_v2.pyare consistent and I didn't miss anything.I expect this module to be used like this: